Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix time.recent method signature #586

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 1, 2022

Superseeds #534
Fixes #533

@ST-DDT ST-DDT added the c: bug Something isn't working label Mar 1, 2022
@ST-DDT ST-DDT self-assigned this Mar 1, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner March 1, 2022 21:17
@ST-DDT ST-DDT force-pushed the fix/time-recents-signature branch from a10923f to c227fcd Compare March 1, 2022 21:18
@Shinigami92 Shinigami92 requested a review from a team March 1, 2022 21:19
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #586 (a88306d) into main (357986b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1920     1920           
  Lines      176414   176424   +10     
  Branches      904      904           
=======================================
+ Hits       175257   175267   +10     
  Misses       1101     1101           
  Partials       56       56           
Impacted Files Coverage Δ
src/faker.ts 100.00% <100.00%> (ø)
src/time.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT mentioned this pull request Mar 1, 2022
5 tasks
@Shinigami92 Shinigami92 merged commit 60d3cc5 into main Mar 2, 2022
@Shinigami92 Shinigami92 deleted the fix/time-recents-signature branch March 2, 2022 20:06
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong param and return types on time.recent
3 participants